New key style[edit]
It would be nice if these key graphics didn't hog so much vertical space. I'm suggesting we scale it down a bit, like wp:Template:Keypress. For comparison, see:
Enter versus .
Also, I think we should add font-weight:normal and font-style:normal to the style so the letter doesn't get bolded or italicized (like in control tables). — najzereT 23:45, 27 February 2010 (UTC)
- How does it work? -- Prod (Talk) 00:16, 28 February 2010 (UTC)
- How does what work? — najzereT 07:58, 28 February 2010 (UTC)
- Current uses two images through a CSS class to build the outer border of the regular text. Is that done the same way, or is it just a css border style or something? -- Prod (Talk) 18:58, 28 February 2010 (UTC)
- They both use a span with border and background color set. The only change needed would be to replace what's currently in MediaWiki:Common.css for the "keyboard_button" class with the new styles. We can get bogged down in details after we decide if we even want to change it. — najzereT 19:30, 28 February 2010 (UTC)
- I like the smaller size, and as long as we keep usage the same it shouldn't be a problem, assuming the community agrees. -- Prod (Talk) 19:59, 28 February 2010 (UTC)
- The smaller size is good when used within a guide, but when used in comparison to joypad controls (such as Grand_Theft_Auto:_San_Andreas/Controls#Vehicles) they may appear a bit 2nd class, and I've seen more guides with control pages than using the keyboard setting in a guide so I'm going to vote we keep the current. On the side, I don't think specific control buttons should be used in any guide as "press use, to open the door" would apply across all platforms and consoles, in comparison to "press , to open the door" - Trevman 22:08, 28 February 2010 (UTC)
- Key/button images in guides are a nice touch and let the reader immediately understand what to press without having to refer back to the Controls page. Use of {{control selector}} lets us switch between images for people on different consoles. I added a controls table (from Final Fantasy VII) for comparison below, and increased the border width slightly. — najzereT 20:43, 1 March 2010 (UTC)
- I know I'm new here, and not very active, but I personally like the smaller one. That being said, why couldn't we have both? Jack Napier 02:11, 2 March 2010 (UTC)
- Key/button images in guides are a nice touch and let the reader immediately understand what to press without having to refer back to the Controls page. Use of {{control selector}} lets us switch between images for people on different consoles. I added a controls table (from Final Fantasy VII) for comparison below, and increased the border width slightly. — najzereT 20:43, 1 March 2010 (UTC)
- The smaller size is good when used within a guide, but when used in comparison to joypad controls (such as Grand_Theft_Auto:_San_Andreas/Controls#Vehicles) they may appear a bit 2nd class, and I've seen more guides with control pages than using the keyboard setting in a guide so I'm going to vote we keep the current. On the side, I don't think specific control buttons should be used in any guide as "press use, to open the door" would apply across all platforms and consoles, in comparison to "press , to open the door" - Trevman 22:08, 28 February 2010 (UTC)
- I like the smaller size, and as long as we keep usage the same it shouldn't be a problem, assuming the community agrees. -- Prod (Talk) 19:59, 28 February 2010 (UTC)
- They both use a span with border and background color set. The only change needed would be to replace what's currently in MediaWiki:Common.css for the "keyboard_button" class with the new styles. We can get bogged down in details after we decide if we even want to change it. — najzereT 19:30, 28 February 2010 (UTC)
- Current uses two images through a CSS class to build the outer border of the regular text. Is that done the same way, or is it just a css border style or something? -- Prod (Talk) 18:58, 28 February 2010 (UTC)
- How does what work? — najzereT 07:58, 28 February 2010 (UTC)
┌───────────────────────┘
I'd say mainly for consistency. It would look pretty weird to go from one guide to the next (or even worse, one page the next) and see different looking keyboard markup. — najzereT 17:09, 3 March 2010 (UTC)
- There's always the possibility of just making the current one slightly smaller. The current line-height is taller than some of the controller buttons, and we can reduce the padding to compensate. -- Prod (Talk) 08:22, 5 March 2010 (UTC)
Comparisons[edit]
- In text
Text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding. Text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding. Keyboard key in a line of text: Enter Much smaller profile, doesn't affect line height. Text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding. Text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding.
Text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding. Text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding. Keyboard key in a line of text:
Much larger profile, creates extra spacing between lines. Text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding. Text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding, text padding.- In tables